Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended language support for multiple languages #3451

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

arcturus140
Copy link
Contributor

Description

This pull request closes #3387. It adds language support for the "Ok" button in multiple languages.

@ZeroX-DG ZeroX-DG added awaiting review ❇️ Pull request is awaiting a review. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Jan 30, 2020
@ZeroX-DG
Copy link
Member

I'll let this open for about a week (maybe less, it's only an "OK" word so u probably get all right) to wait for any review, if everyone agree with it we will merge it.

@arcturus140
Copy link
Contributor Author

ok

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Feb 5, 2020

It's seem your PR is ok. I'll notify @Rokt33r to merge it

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Feb 5, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 5, 2020
@Rokt33r Rokt33r merged commit 216f588 into BoostIO:master Feb 5, 2020
@arcturus140 arcturus140 deleted the fix3387 branch February 14, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization for "Ok" word
3 participants