Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #71

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Remove unnecessary dependencies #71

merged 3 commits into from
Aug 1, 2022

Conversation

jwoloch
Copy link
Contributor

@jwoloch jwoloch commented Jul 31, 2022

Having golangci-lint and witch imported in tools.go generates awful number of dependencies that are not required at all for this library to work. Maybe we could remove it?

@jwoloch
Copy link
Contributor Author

jwoloch commented Jul 31, 2022

I see that there was similar PR #70, but still having read that conversation I would like to reopen this discussion. Currently importing this library into my project more then doubles number of dependencies :/

For example, current way of installing golangci-lint is discouraged by authors: https://golangci-lint.run/usage/install/#install-from-source

@F21
Copy link
Member

F21 commented Aug 1, 2022

Thanks for opening this. I agree that the transitive dependencies introduced by the development dependencies pollutes the actual dependency tree of the project.

There's some discussion in golang/go#48429 (comment) regarding support for pinning development dependencies, but it is unclear what the implementation timeline would look like in the near-term.

I've been thinking about removing witch from the project as I personally don't use it all that often now and the project appears to be unmaintained. For golang-ci-lint, I think a good workaround would be to download the binary in the makefile and remove it from go.mod until a better solution is available.

@F21 F21 merged commit fd7fde6 into Boostport:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants