feat: accumulate locked balance in TokenHolder collection batch #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplesmoke05
commented
Jan 31, 2023
Comment on lines
+89
to
+100
| class TokenHoldersCollectionHolder(BaseModel): | ||
| account_address: str = Field(description="Account address of token holder.") | ||
| hold_balance: int = Field(description="Amount of balance." | ||
| "This includes balance/pending_transfer/exchange_balance/exchange_commitment.") | ||
| locked_balance: int = Field(description="Amount of locked balance.") | ||
|
|
||
|
|
||
| class RetrieveTokenHoldersListResponse(BaseModel): | ||
| """Retrieve Token Holders List schema (RESPONSE)""" | ||
|
|
||
| status: TokenHolderBatchStatus | ||
| holders: List[Dict[str, Union[int, str]]] | ||
| holders: List[TokenHoldersCollectionHolder] |
There was a problem hiding this comment.
Detailed Response schema.
purplesmoke05
commented
Jan 31, 2023
Comment on lines
+56
to
+65
| def store(self, account_address: str, amount: int = 0, locked: int = 0): | ||
| if account_address not in self.pages: | ||
| token_holder = TokenHolder() | ||
| token_holder.hold_balance = amount | ||
| token_holder.hold_balance = 0 + amount | ||
| token_holder.account_address = account_address | ||
| token_holder.locked_balance = 0 + locked | ||
| self.pages[account_address] = token_holder | ||
| else: | ||
| self.pages[account_address].hold_balance += amount | ||
| self.pages[account_address].locked_balance += locked |
There was a problem hiding this comment.
- Added
locked_balancefield.- Each method in processor calls this to accumulate locked amount.
- locked balance is to be counted separately from hold balance.
YoshihitoAso
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #471
Changes
Batch
indexer_token_holders.pyAPI
/holders/{token_address}/collection