Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] token: Add currency code attribute #423

Closed
YoshihitoAso opened this issue Oct 2, 2023 · 1 comment · Fixed by #424
Closed

[FEATURE] token: Add currency code attribute #423

YoshihitoAso opened this issue Oct 2, 2023 · 1 comment · Fixed by #424
Assignees
@YoshihitoAso
Labels
enhancement New feature or request

Comments

@YoshihitoAso
Copy link
Member

Is your feature request related to a problem? Please describe.

Numerical items such as the token issuance price are currently defined as integers, but this is because it is intended to be used only in Japanese yen. On the other hand, I would like to be able to use tokens other than those denominated in Japanese yen.

Describe the solution you'd like

I would like to add a currency code as a token attribute and also be able to represent a decimal point.
@YoshihitoAso YoshihitoAso added the enhancement New feature or request label Oct 2, 2023
@YoshihitoAso YoshihitoAso self-assigned this Oct 2, 2023
@YoshihitoAso YoshihitoAso moved this to Todo in ibet-OSS v23.12 Oct 2, 2023
This was referenced Oct 2, 2023
Closed
Closed
@purplesmoke05 purplesmoke05 mentioned this issue Oct 27, 2023
Merged
YoshihitoAso added a commit that referenced this issue Oct 27, 2023
@YoshihitoAso
Merge pull request #424 from BoostryJP/feature/#423
77e3132 
Add currency attributes to ibetStraightBond contract
@github-project-automation github-project-automation bot moved this from Todo to Done in ibet-OSS v23.12 Oct 27, 2023
@YoshihitoAso
Copy link
Member Author

Made further fixes in the commit below.
b23a600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoshihitoAso YoshihitoAso

Labels
enhancement New feature or request
Projects
No open projects
ibet-OSS v23.12
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add currency attributes to ibetStraightBond contract BoostryJP/ibet-SmartContract
1 participant
@YoshihitoAso