Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make registration of personal information optional #437

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Make registration of personal information optional #437

merged 3 commits into from
Apr 1, 2024

Conversation

YoshihitoAso
Copy link
Member

@YoshihitoAso YoshihitoAso commented Mar 29, 2024 •
edited
Loading

close #434

  • The specifications have been changed so that it is possible to control whether or not personal information registration is required when transferring security tokens.
  • The default setting when issuing a new token is True (registration required), and the owner can update whether registration is required.

@YoshihitoAso YoshihitoAso marked this pull request as ready for review March 29, 2024 17:14
YoshihitoAso
YoshihitoAso commented Mar 31, 2024
View reviewed changes
tests/Dockerfile_unittest
@@ -61,7 +61,7 @@ RUN pip install --upgrade pip setuptools \
COPY --chown=apl:apl package.json /app/ibet-SmartContract
COPY --chown=apl:apl package-lock.json /app/ibet-SmartContract
COPY --chown=apl:apl hardhat.config.js /app/ibet-SmartContract
RUN npm install --save-dev hardhat
RUN npm install --only=dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a mistake in npm installation, so I fixed it in this version.

purplesmoke05
purplesmoke05 approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@purplesmoke05 purplesmoke05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshihitoAso YoshihitoAso merged commit 0c8c87d into dev-24.6 Apr 1, 2024
@YoshihitoAso YoshihitoAso deleted the feature/#434 branch April 1, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplesmoke05 purplesmoke05 purplesmoke05 approved these changes

Assignees

@YoshihitoAso YoshihitoAso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make registration of personal information optional when transferring security tokens
2 participants
@YoshihitoAso @purplesmoke05