Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add clarification to RPC section #348

Merged
merged 2 commits into from
Jan 2, 2025
Merged

docs: Add clarification to RPC section #348

merged 2 commits into from
Jan 2, 2025

Conversation

mgarciap
Copy link
Member

@mgarciap mgarciap commented Dec 18, 2024 •
edited
Loading

Closes #

Description:

Add clarification to the RPC section

Steps:

NA

Type of change:

  • New feature
  • Bug fix
  • Breaking change
  • Enhancement
  • Refactoring
  • Chore

How Has This Been Tested?

  • Manual testing
  • Automated tests
  • Other (explain)

Remember to check that:

  • Your code follows the style guidelines of this project
  • You have performed a self-review of your code
  • You have commented your code in hard-to-understand areas
  • You have made corresponding changes to the documentation
  • Your changes generate no new warnings

Screenshots

(Add screenshots or videos to help test this pull request)

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024

@mgarciap is attempting to deploy a commit to the BootNode Team on Vercel.

A member of the Team first needs to authorize it.

@mgarciap mgarciap changed the title Add clarification to RPC section doc: Add clarification to RPC section Dec 18, 2024
@mgarciap mgarciap changed the title doc: Add clarification to RPC section docs: Add clarification to RPC section Dec 18, 2024
@gabitoesmiapodo gabitoesmiapodo self-requested a review January 2, 2025 19:57
gabitoesmiapodo
gabitoesmiapodo approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@gabitoesmiapodo gabitoesmiapodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a mess, we should disallow this person from further access to this repository 🙄

@gabitoesmiapodo gabitoesmiapodo self-requested a review January 2, 2025 19:58
@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dappbooster ✅ Ready (Inspect) Visit Preview Jan 2, 2025 8:01pm
docs.dappbooster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:01pm

@gabitoesmiapodo gabitoesmiapodo merged commit b581b3e into BootNodeDev:develop Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabitoesmiapodo gabitoesmiapodo gabitoesmiapodo approved these changes

Assignees

@mgarciap mgarciap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgarciap @gabitoesmiapodo