-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(MeiliSearch): add update list extension method #137
Conversation
Reviewer's Guide by SourceryThis PR implements a customizable update list functionality for MeiliSearch by introducing a global extension point. The changes allow for custom handling of search results through a configurable callback mechanism. Sequence diagram for the updated search result handlingsequenceDiagram
participant User
participant MeiliSearchBox
participant MeiliSearchClient
participant BootstrapBlazor
User->>MeiliSearchBox: Initiate search
MeiliSearchBox->>MeiliSearchClient: Create client with options
MeiliSearchClient->>MeiliSearchBox: Return search results
MeiliSearchBox->>BootstrapBlazor: Check for custom updateList
alt Custom updateList exists
BootstrapBlazor->>MeiliSearchBox: Execute custom updateList
else
MeiliSearchBox->>MeiliSearchBox: Execute default updateList
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR description template with impact assessment and verification details.
- Consider adding documentation about the new updateList extension point and how developers can use it.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
add update list extension method
Summary of the changes (Less than 80 chars)
Description
fixes #136
Customer Impact
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: