Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Config): update project toolchain #163

Merged
merged 2 commits into from
Dec 10, 2024
Merged

chore(Config): update project toolchain #163

merged 2 commits into from
Dec 10, 2024

Conversation

ArgoZhang
Copy link
Contributor

@ArgoZhang ArgoZhang commented Dec 10, 2024

update project toolchain

Summary of the changes (Less than 80 chars)

Description

fixes #162

Customer Impact

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the project toolchain by upgrading the .NET SDK version in the CI workflow and enhancing the bug report issue template with a dropdown for .NET version selection.

Build:

  • Update the .NET SDK version in the GitHub Actions workflow to 9.0.x.

CI:

  • Modify the bug report issue template to use a dropdown for selecting the .NET version, with options for NET9.0, NET8.0, NET7.0, and NET6.0.

@bb-auto bb-auto bot added the chore label Dec 10, 2024
Copy link

sourcery-ai bot commented Dec 10, 2024

Reviewer's Guide by Sourcery

This PR updates the project toolchain by modifying the bug report template and GitHub Actions workflow. The main changes include converting the .NET version input to a dropdown selection and upgrading the .NET SDK version from 8.0.x to 9.0.x in the CI pipeline.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enhanced bug report template with structured .NET version selection
  • Changed .NET version field from free-form input to dropdown selection
  • Added options for .NET versions 6.0 through 9.0
  • Set default selection to NET8.0 (index 1)
.github/ISSUE_TEMPLATE/10_bug_report.yml
Updated CI pipeline to use latest .NET SDK
  • Upgraded .NET SDK version from 8.0.x to 9.0.x
.github/workflows/auto-pull-request-checks.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#162 Update project toolchain by upgrading .NET SDK version from 8.0.x to 9.0.x
#162 Update bug report template to use dropdown for .NET versions instead of free-form input

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 10, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 10, 2024 02:34
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider maintaining .NET 8.0 as the primary SDK version for now since .NET 9.0 is still in preview. You could add .NET 9.0 as an additional test target instead of making it the primary version.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/ISSUE_TEMPLATE/10_bug_report.yml Show resolved Hide resolved
@ArgoZhang ArgoZhang disabled auto-merge December 10, 2024 02:36
@ArgoZhang ArgoZhang merged commit 33fdbd8 into master Dec 10, 2024
1 of 2 checks passed
@ArgoZhang ArgoZhang deleted the chore-config branch December 10, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(Config): update project toolchain
1 participant