-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Config): update project toolchain #163
Conversation
Reviewer's Guide by SourceryThis PR updates the project toolchain by modifying the bug report template and GitHub Actions workflow. The main changes include converting the .NET version input to a dropdown selection and upgrading the .NET SDK version from 8.0.x to 9.0.x in the CI pipeline. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider maintaining .NET 8.0 as the primary SDK version for now since .NET 9.0 is still in preview. You could add .NET 9.0 as an additional test target instead of making it the primary version.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
update project toolchain
Summary of the changes (Less than 80 chars)
Description
fixes #162
Customer Impact
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the project toolchain by upgrading the .NET SDK version in the CI workflow and enhancing the bug report issue template with a dropdown for .NET version selection.
Build:
CI: