Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Editor): add async key word #168

Merged
merged 1 commit into from
Dec 10, 2024
Merged

feat(Editor): add async key word #168

merged 1 commit into from
Dec 10, 2024

Conversation

ArgoZhang
Copy link
Contributor

@ArgoZhang ArgoZhang commented Dec 10, 2024

add async key word

Summary of the changes (Less than 80 chars)

Description

fixes #167

Customer Impact

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Introduce asynchronous functionality to the Editor component by adding the 'async' keyword to the 'init' function.

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 10, 2024
Copy link

sourcery-ai bot commented Dec 10, 2024

Reviewer's Guide by Sourcery

The PR adds the 'async' keyword to the init function in the Editor component's JavaScript file, making it explicitly asynchronous.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the init function signature to be explicitly asynchronous
  • Added 'async' keyword to the init function declaration
src/components/BootstrapBlazor.SummerNote/Components/Editor/Editor.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#167 Add async keyword to the init function in Editor.razor.js

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 10, 2024
@ArgoZhang ArgoZhang merged commit dff21e5 into master Dec 10, 2024
1 check passed
@ArgoZhang ArgoZhang deleted the refactor-editor branch December 10, 2024 04:22
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide context for why the init function needs to be async. Are there asynchronous operations being performed inside the function that we're not seeing in this diff?
  • Making a function async changes its return type to Promise. Have you verified this doesn't break any existing code that calls this function?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Editor): add async key word
1 participant