-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Gantt): update static assets link #188
Conversation
Reviewer's Guide by SourceryThis PR updates the static asset handling in the Gantt component by removing the static CSS link from the Razor component and moving it to be loaded dynamically via JavaScript. The CSS file reference has also been updated to use a bundled version. Sequence diagram for dynamic CSS loading in Gantt componentsequenceDiagram
participant User
participant Browser
participant GanttComponent
participant JavaScript
User->>Browser: Load Gantt Component
Browser->>GanttComponent: Initialize
GanttComponent->>JavaScript: Call init function
JavaScript->>JavaScript: Check if CSS is already loaded
alt CSS not loaded
JavaScript->>JavaScript: Load gantt.bundle.css
end
JavaScript->>GanttComponent: Continue initialization
GanttComponent->>Browser: Render Gantt
Browser->>User: Display Gantt Chart
Updated class diagram for Gantt componentclassDiagram
class GanttComponent {
+string Id
+string ClassString
+Dictionary AdditionalAttributes
+void init()
}
note for GanttComponent "Removed static CSS link from Razor component"
class JavaScript {
+async void addLink(string url)
}
note for JavaScript "Updated to load gantt.bundle.css dynamically"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please properly fill out the PR template, particularly the Customer Impact and Risk sections. This helps reviewers understand the context and implications of the changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
update static assets link
Summary of the changes (Less than 80 chars)
Description
fixes #187
Customer Impact
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: