Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Gantt): update static assets link #188

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

ArgoZhang
Copy link
Contributor

@ArgoZhang ArgoZhang commented Dec 16, 2024

update static assets link

Summary of the changes (Less than 80 chars)

Description

fixes #187

Customer Impact

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Update the static asset link in the Gantt component to use 'gantt.bundle.css' instead of 'frappe-gantt.min.css'.

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 16, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 16, 2024
Copy link

sourcery-ai bot commented Dec 16, 2024

Reviewer's Guide by Sourcery

This PR updates the static asset handling in the Gantt component by removing the static CSS link from the Razor component and moving it to be loaded dynamically via JavaScript. The CSS file reference has also been updated to use a bundled version.

Sequence diagram for dynamic CSS loading in Gantt component

sequenceDiagram
    participant User
    participant Browser
    participant GanttComponent
    participant JavaScript

    User->>Browser: Load Gantt Component
    Browser->>GanttComponent: Initialize
    GanttComponent->>JavaScript: Call init function
    JavaScript->>JavaScript: Check if CSS is already loaded
    alt CSS not loaded
        JavaScript->>JavaScript: Load gantt.bundle.css
    end
    JavaScript->>GanttComponent: Continue initialization
    GanttComponent->>Browser: Render Gantt
    Browser->>User: Display Gantt Chart
Loading

Updated class diagram for Gantt component

classDiagram
    class GanttComponent {
        +string Id
        +string ClassString
        +Dictionary AdditionalAttributes
        +void init()
    }
    note for GanttComponent "Removed static CSS link from Razor component"

    class JavaScript {
        +async void addLink(string url)
    }
    note for JavaScript "Updated to load gantt.bundle.css dynamically"
Loading

File-Level Changes

Change Details Files
Refactor static CSS loading mechanism
  • Remove static CSS link from HeadContent section
  • Remove unused Microsoft.AspNetCore.Components.Web using statement
  • Update JavaScript to load bundled CSS file dynamically
  • Change CSS file reference from frappe-gantt.min.css to gantt.bundle.css
src/components/BootstrapBlazor.Gantt/Components/Gantt.razor
src/components/BootstrapBlazor.Gantt/Components/Gantt.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#187 Update static assets link from frappe-gantt.min.css to gantt.bundle.css

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please properly fill out the PR template, particularly the Customer Impact and Risk sections. This helps reviewers understand the context and implications of the changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 51faff8 into master Dec 16, 2024
1 check passed
@ArgoZhang ArgoZhang deleted the refactor-gantt branch December 16, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(Gantt): update static assets link
1 participant