-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CodeEditor): remove css isolation #194
Conversation
Reviewer's Guide by SourceryThis PR removes CSS isolation from the CodeEditor component by moving the CSS from a scoped file to a bundled CSS file and updating the JavaScript initialization to load the bundled CSS file. Class diagram for CodeEditor component changesclassDiagram
class CodeEditor {
- init(id, interop, options)
}
class CodeEditorCSS {
+ code-editor.bundle.css
}
CodeEditor --> CodeEditorCSS : uses
note for CodeEditor "JavaScript initialization updated to load bundled CSS file"
note for CodeEditorCSS "CSS moved from scoped file to bundled CSS file"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the PR template completely, especially the Customer Impact and Risk sections, as removing CSS isolation could have broader implications.
- Could you explain the rationale for removing CSS isolation? This architectural change should be documented with its benefits and potential impacts.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
remove css isolation
Summary of the changes (Less than 80 chars)
Description
fixes #193
Customer Impact
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: