Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports + strict & fixing Docs #5

Merged
merged 18 commits into from
Oct 28, 2020
Merged

imports + strict & fixing Docs #5

merged 18 commits into from
Oct 28, 2020

Conversation

Borda
Copy link
Owner

@Borda Borda commented Apr 14, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pep8speaks
Copy link

pep8speaks commented Apr 14, 2020

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-28 13:43:01 UTC

Repository owner deleted a comment from lgtm-com bot Oct 27, 2020
Repository owner deleted a comment from lgtm-com bot Oct 27, 2020
Repository owner deleted a comment from lgtm-com bot Oct 27, 2020
Repository owner deleted a comment from lgtm-com bot Oct 27, 2020
Repository owner deleted a comment from lgtm-com bot Oct 28, 2020
@Borda Borda marked this pull request as ready for review October 28, 2020 13:17
@Borda Borda changed the title strict & fixing Docs imports + strict & fixing Docs Oct 28, 2020
Repository owner deleted a comment from lgtm-com bot Oct 28, 2020
Repository owner deleted a comment from lgtm-com bot Oct 28, 2020
Repository owner deleted a comment from lgtm-com bot Oct 28, 2020
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2020

This pull request fixes 1 alert when merging 9449ba6 into 68c7ffa - view on LGTM.com

fixed alerts:

  • 1 for Redundant assignment

@Borda Borda merged commit 5479ac1 into master Oct 28, 2020
@Borda Borda deleted the devel branch October 28, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants