Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in parse empty tag in mp3 file? #16

Closed
KHALED-LAKEHAL opened this issue Jul 8, 2017 · 2 comments
Closed

Error in parse empty tag in mp3 file? #16

KHALED-LAKEHAL opened this issue Jul 8, 2017 · 2 comments
Labels
bug Bug, will addressed with high priority

Comments

@KHALED-LAKEHAL
Copy link

this data show when parse mp3 file when this not have any tag
capture

when add tag to this file

capture
@Borewit
Copy link
Owner

Borewit commented Jul 9, 2017

In case no ID3v2 tags are found, the parser tries to read ID3v1.1 tags.
It looks like it is not checking if the ID3v1.1 tags are set..
I will fix it, thanks for reporting this.

@Borewit Borewit added the bug Bug, will addressed with high priority label Jul 9, 2017
Borewit added a commit that referenced this issue Jul 9, 2017
@Borewit
Added unit test ensure MP3-file with no tags set is handled correctly…
d51979d 
…. (Issue #16)
Borewit added a commit that referenced this issue Jul 9, 2017
@Borewit
Fix issue #16, parse MP3 without any tags.
660a76f
@Borewit
Copy link
Owner

Borewit commented Jul 9, 2017

Fixed in v0.7.4

@Borewit Borewit closed this as completed Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug, will addressed with high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Borewit @KHALED-LAKEHAL