-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove .ts files from published npm module #25
Comments
I deliberately put the TypeScript files (*.ts) back in the distribution after having lots of issues with other tools like debuggers, not trigger recompile after changes, debugging on JavaScript instead of TypeScript, generating JavaScript files in both the distribution folder and the source folder. I figured by doing this, it would also make debugging easier as the TypeScript files, with the map files, would allow debuggers to use the original source (TypeScript) instead of the generated JavaScript files. Hmm... dammit. |
as per TypeStrong/ts-loader#278 , tsloader cannot compile ts from node_modules. And they don't plan to add it in future. It might be better to bundle it with webpack to distribute it. Anyone with advanced use cases can clone the sources into the project itself. |
I hope this one fixes your problem v0.7.13, please confirm. |
v0.7.13 is working perfectly. Thank you for solving it real quick. |
The published npm module contains both the typescript and javascript files.
When using the module with tsloader and webpack, it throws about 117 errors.
This occurs due to tsloader trying to load the .ts files instead of .js ones. Setting allowsJs to true does not resolve the errors.
When i manually delete the .ts files while keeping the .js and .d.ts files, the module works perfectly.
This occurs for both music-metadata and strtok3.
The text was updated successfully, but these errors were encountered: