Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make IMusicBrainzConfig.baseUrl optional again #976

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Haschikeks
Copy link
Collaborator

Hi,
the change to make the baseUrl required could break builds and is not mentioned in the docs.
As far as I can see, it still can be optional and we might need to cast the baseUrl for the httpClient to a string again.

export interface IMusicBrainzConfig {
botAccount?: {
username?: string,
password?: string
},
baseUrl: string,
appName?: string,
appVersion?: string,

@Haschikeks Haschikeks requested a review from Borewit August 27, 2024 08:14
@Borewit
Copy link
Owner

Borewit commented Aug 27, 2024

Good catch Max.
I prevented the requirement to cast the baseUrl: 42b6777, happy with that change?

@Haschikeks
Copy link
Collaborator Author

That looks good to me.

@Borewit Borewit merged commit 974cf50 into Borewit:master Aug 28, 2024
5 checks passed
@Borewit
Copy link
Owner

Borewit commented Aug 28, 2024

Fixed in v0.18.2

@Borewit Borewit added the bug Something isn't working label Aug 28, 2024
@Haschikeks Haschikeks deleted the fix-baseurl-optional branch August 28, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants