make IMusicBrainzConfig.baseUrl
optional again
#976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the change to make the
baseUrl
required could break builds and is not mentioned in the docs.As far as I can see, it still can be optional and we might need to cast the
baseUrl
for the httpClient to a string again.musicbrainz-api/lib/musicbrainz-api.ts
Lines 129 to 137 in 52d05f9