add external pgvector #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Could you please change target branch to 'dev' instead since we have other on going updates to be merged as well. |
|
changed to dev |
BorisPolonsky
requested changes
Jun 26, 2024
charts/dify/templates/config.tpl
Outdated
| @@ -232,7 +242,6 @@ MILVUS_PORT: {{ .Values.externalMilvus.port | toString | quote }} | |||
| # The milvus password. | |||
| # MILVUS_PASSWORD: {{ .Values.externalMilvus.password | quote }} | |||
| # The milvus tls switch. | |||
| MILVUS_SECURE: {{ .Values.externalMilvus.useTLS | toString | quote }} | |||
There was a problem hiding this comment.
Please restore this config@FingerLiu
|
done |
BorisPolonsky
previously approved these changes
Jun 27, 2024
BorisPolonsky
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Please restore Milvus TLS config.
0496750#diff-b66d04a8a753c83075f115c52ba2ba47bebe8e3205335f8ddca381903fb74397L235
|
restored Milvus TLS config |
BorisPolonsky
approved these changes
Jul 2, 2024
Merged
BorisPolonsky
added a commit
that referenced
this pull request
Aug 1, 2024
* Add Release chart action & bump chart version (#3) * Add helm chart release logic * Bump chart version * Add installation guide (#4) * Fix env clash (#9) * Fix ENV clashing for some corner case * Bump chart version to 0.14.1 * Fix label in worker deployment (#12) * Bump chart version to 0.15.0 * 0.3.8 compatibility for core components (#14) - Fix compatibility issue with URL related ENV introduced in `0.3.8` - langgenius/dify#648 - #11 * Bump chart version to 0.16.0 * Fix postgres port and database config (#18) - Fix port configuration when external postgres exposes port other than 5432 - Fix database conofiguration when utilizing external postgres * Update Chart.yaml Bump version to 0.16.1 * Update README.md Fix grammar * Create LICENSE * Update README.md Add download badge * Update README.md * Dify 0.4.9 support (#28) * Add new environment variables to templates * Update nginx routing * Remove redundant environment vairables * Update milvus config * Update URL setting * Quote environment variables * Update README.md * Bump chart version to 0.17.0 * Update mail config * Remove redundant extraEnv * Bump appVersion to 0.4.9 * Update README.md (#31) * Revert "Update README.md" (#32) * Display contributors (#33) * Fix README.md (#26) * Add Release chart action & bump chart version (#3) * Add helm chart release logic * Bump chart version * Add installation guide (#4) * Fix env clash (#9) * Fix ENV clashing for some corner case * Bump chart version to 0.14.1 * Fix label in worker deployment (#12) * Bump chart version to 0.15.0 * 0.3.8 compatibility for core components (#14) - Fix compatibility issue with URL related ENV introduced in `0.3.8` - langgenius/dify#648 - #11 * Bump chart version to 0.16.0 * Fix postgres port and database config (#18) - Fix port configuration when external postgres exposes port other than 5432 - Fix database conofiguration when utilizing external postgres * Update Chart.yaml Bump version to 0.16.1 * Update README.md Fix grammar * Create LICENSE * Update README.md Add download badge * Update README.md * Dify 0.4.9 Compatibility (#30) * Add Release chart action & bump chart version (#3) * Add helm chart release logic * Bump chart version * Add installation guide (#4) * Fix env clash (#9) * Fix ENV clashing for some corner case * Bump chart version to 0.14.1 * Fix label in worker deployment (#12) * Bump chart version to 0.15.0 * 0.3.8 compatibility for core components (#14) - Fix compatibility issue with URL related ENV introduced in `0.3.8` - langgenius/dify#648 - #11 * Bump chart version to 0.16.0 * Fix postgres port and database config (#18) - Fix port configuration when external postgres exposes port other than 5432 - Fix database conofiguration when utilizing external postgres * Update Chart.yaml Bump version to 0.16.1 * Update README.md Fix grammar * Create LICENSE * Update README.md Add download badge * Update README.md * Dify 0.4.9 support (#28) * Add new environment variables to templates * Update nginx routing * Remove redundant environment vairables * Update milvus config * Update URL setting * Quote environment variables * Update README.md * Bump chart version to 0.17.0 * Update mail config * Remove redundant extraEnv * Bump appVersion to 0.4.9 * feat: add files path to nginx proxy config (#29) Resolves the issue of files not being available in the frontend, e.g. DALL-E generated images. Co-authored-by: Boris Polonsky <BorisPolonsky@users.noreply.github.com> * Update README.md --------- Co-authored-by: Pascal M <11357019+perzeuss@users.noreply.github.com> * Update release condition * Update values.yaml Update comments on vector db in values.yaml * Update values.yaml Grammar fix * Fix ConfigMap error when `.Values.externalMilvus.enable=true` * Fix nginx duplicate location: "/files" * Bump Chart version to 0.17.1 * Optimize extraEnv configuration * Bump Chart Version to 0.17.2 * Change chart version to 0.17.2-rc1 * Bump chart version to 0.17.2 * add quote to QDRANT_CLIENT_TIMEOUT/consoleApi/appApi #45 lack of quote cause creating configmap error * Rename port in service as name: `<protocol>[-<suffix>]` format and make them compatible with explicit protocol selection in `istio` * Bump Chart version to 0.18.0 * Update comment * 0.5.11 compatiblity update * Update PVC definition logic in `api` and `worker` * Update comment on custom environment variables * Fix log level definition in `worker` * Dify 0.6.3 compatibility (WIP) * Update indentation of `envFrom` in `web`, `worker` and `api` * Corrected port config and remove redundant template in deployment `sandbox` * Fix incorrect variable type in `config.tpl` * Fix value reference in credentials.tpl * Add secret for `sandbox` * Removed existingSecret related config in section `sandbox` in `values.yaml` * Rename template * Add and mount secret for `api` and `worker` * Removed credentials from configmap * Removed hard-coded config for sandbox in `config.tpl` * Fix typo and correct priviledge escalation config for sandbox * Corrected `appVersion` * Corrected typo * Support Aliyun OSS (#74) * Support Aliyun OSS * Fix sandbox API_KEY * add external pgvector (#79) * Dify 0.6.11 compatibility update (#81) * Add ssrf_poroxy (WIP) * Fix squid image configuration * Complete squid log and routing config * Remove `squid` cache * Include `ssrf_proxy` configuration in `api` * Add `CODE_EXECUTION_API_KEY` in `api` * Update configuration of sandbox - Added `ssrf_proxy` support - Overhauled `dify.sandbox.fullname` definition * Fix ssrf proxy configuration in `api` * Restore ssrf_proxy default confiuration after unit tests * Breaking Change: Update default SMTP configuration and layout in `.Values.api` * Update priority and comment of exteranal storage configuration * Update external qdrant configuartion * Update priority of `pgvector` * Update priority of `aliyun_oss` * Update order of object storage types in `values.yaml` * Update order of vector db in `values.yaml` --------- Co-authored-by: Pascal M <11357019+perzeuss@users.noreply.github.com> Co-authored-by: Ryan <haoinit@gmail.com> Co-authored-by: Li Yi <denverdino@gmail.com> Co-authored-by: FingerLiu <liupeng.dalian@gmail.com>
regnull
pushed a commit
to regnull/dify-helm
that referenced
this pull request
Dec 30, 2024
* Add Release chart action & bump chart version (BorisPolonsky#3) * Add helm chart release logic * Bump chart version * Add installation guide (BorisPolonsky#4) * Fix env clash (BorisPolonsky#9) * Fix ENV clashing for some corner case * Bump chart version to 0.14.1 * Fix label in worker deployment (BorisPolonsky#12) * Bump chart version to 0.15.0 * 0.3.8 compatibility for core components (BorisPolonsky#14) - Fix compatibility issue with URL related ENV introduced in `0.3.8` - langgenius/dify#648 - BorisPolonsky#11 * Bump chart version to 0.16.0 * Fix postgres port and database config (BorisPolonsky#18) - Fix port configuration when external postgres exposes port other than 5432 - Fix database conofiguration when utilizing external postgres * Update Chart.yaml Bump version to 0.16.1 * Update README.md Fix grammar * Create LICENSE * Update README.md Add download badge * Update README.md * Dify 0.4.9 support (BorisPolonsky#28) * Add new environment variables to templates * Update nginx routing * Remove redundant environment vairables * Update milvus config * Update URL setting * Quote environment variables * Update README.md * Bump chart version to 0.17.0 * Update mail config * Remove redundant extraEnv * Bump appVersion to 0.4.9 * Update README.md (BorisPolonsky#31) * Revert "Update README.md" (BorisPolonsky#32) * Display contributors (BorisPolonsky#33) * Fix README.md (BorisPolonsky#26) * Add Release chart action & bump chart version (BorisPolonsky#3) * Add helm chart release logic * Bump chart version * Add installation guide (BorisPolonsky#4) * Fix env clash (BorisPolonsky#9) * Fix ENV clashing for some corner case * Bump chart version to 0.14.1 * Fix label in worker deployment (BorisPolonsky#12) * Bump chart version to 0.15.0 * 0.3.8 compatibility for core components (BorisPolonsky#14) - Fix compatibility issue with URL related ENV introduced in `0.3.8` - langgenius/dify#648 - BorisPolonsky#11 * Bump chart version to 0.16.0 * Fix postgres port and database config (BorisPolonsky#18) - Fix port configuration when external postgres exposes port other than 5432 - Fix database conofiguration when utilizing external postgres * Update Chart.yaml Bump version to 0.16.1 * Update README.md Fix grammar * Create LICENSE * Update README.md Add download badge * Update README.md * Dify 0.4.9 Compatibility (BorisPolonsky#30) * Add Release chart action & bump chart version (BorisPolonsky#3) * Add helm chart release logic * Bump chart version * Add installation guide (BorisPolonsky#4) * Fix env clash (BorisPolonsky#9) * Fix ENV clashing for some corner case * Bump chart version to 0.14.1 * Fix label in worker deployment (BorisPolonsky#12) * Bump chart version to 0.15.0 * 0.3.8 compatibility for core components (BorisPolonsky#14) - Fix compatibility issue with URL related ENV introduced in `0.3.8` - langgenius/dify#648 - BorisPolonsky#11 * Bump chart version to 0.16.0 * Fix postgres port and database config (BorisPolonsky#18) - Fix port configuration when external postgres exposes port other than 5432 - Fix database conofiguration when utilizing external postgres * Update Chart.yaml Bump version to 0.16.1 * Update README.md Fix grammar * Create LICENSE * Update README.md Add download badge * Update README.md * Dify 0.4.9 support (BorisPolonsky#28) * Add new environment variables to templates * Update nginx routing * Remove redundant environment vairables * Update milvus config * Update URL setting * Quote environment variables * Update README.md * Bump chart version to 0.17.0 * Update mail config * Remove redundant extraEnv * Bump appVersion to 0.4.9 * feat: add files path to nginx proxy config (BorisPolonsky#29) Resolves the issue of files not being available in the frontend, e.g. DALL-E generated images. Co-authored-by: Boris Polonsky <BorisPolonsky@users.noreply.github.com> * Update README.md --------- Co-authored-by: Pascal M <11357019+perzeuss@users.noreply.github.com> * Update release condition * Update values.yaml Update comments on vector db in values.yaml * Update values.yaml Grammar fix * Fix ConfigMap error when `.Values.externalMilvus.enable=true` * Fix nginx duplicate location: "/files" * Bump Chart version to 0.17.1 * Optimize extraEnv configuration * Bump Chart Version to 0.17.2 * Change chart version to 0.17.2-rc1 * Bump chart version to 0.17.2 * add quote to QDRANT_CLIENT_TIMEOUT/consoleApi/appApi BorisPolonsky#45 lack of quote cause creating configmap error * Rename port in service as name: `<protocol>[-<suffix>]` format and make them compatible with explicit protocol selection in `istio` * Bump Chart version to 0.18.0 * Update comment * 0.5.11 compatiblity update * Update PVC definition logic in `api` and `worker` * Update comment on custom environment variables * Fix log level definition in `worker` * Dify 0.6.3 compatibility (WIP) * Update indentation of `envFrom` in `web`, `worker` and `api` * Corrected port config and remove redundant template in deployment `sandbox` * Fix incorrect variable type in `config.tpl` * Fix value reference in credentials.tpl * Add secret for `sandbox` * Removed existingSecret related config in section `sandbox` in `values.yaml` * Rename template * Add and mount secret for `api` and `worker` * Removed credentials from configmap * Removed hard-coded config for sandbox in `config.tpl` * Fix typo and correct priviledge escalation config for sandbox * Corrected `appVersion` * Corrected typo * Support Aliyun OSS (BorisPolonsky#74) * Support Aliyun OSS * Fix sandbox API_KEY * add external pgvector (BorisPolonsky#79) * Dify 0.6.11 compatibility update (BorisPolonsky#81) * Add ssrf_poroxy (WIP) * Fix squid image configuration * Complete squid log and routing config * Remove `squid` cache * Include `ssrf_proxy` configuration in `api` * Add `CODE_EXECUTION_API_KEY` in `api` * Update configuration of sandbox - Added `ssrf_proxy` support - Overhauled `dify.sandbox.fullname` definition * Fix ssrf proxy configuration in `api` * Restore ssrf_proxy default confiuration after unit tests * Breaking Change: Update default SMTP configuration and layout in `.Values.api` * Update priority and comment of exteranal storage configuration * Update external qdrant configuartion * Update priority of `pgvector` * Update priority of `aliyun_oss` * Update order of object storage types in `values.yaml` * Update order of vector db in `values.yaml` --------- Co-authored-by: Pascal M <11357019+perzeuss@users.noreply.github.com> Co-authored-by: Ryan <haoinit@gmail.com> Co-authored-by: Li Yi <denverdino@gmail.com> Co-authored-by: FingerLiu <liupeng.dalian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.