Show component values in list (+ other minor conveniences) #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaulting the setting to board priority means that by default all work done will be lost if you forget to click the export button. This is dangerous and confusing, so instead this saves work by default. It would be better to also warn when the dialog is closed without exporting, when the setting is the other way.
If in database priority mode, set the board's part to the database's part rather than erasing it.
This adds an "LCSC Params" field to the footprint and part selection lists that makes it much easier to double-check the assignments or select the right part. Particularly for passives, LCSC buries the important data (like the resistance of a resistor) in the middle of the description field. This pulls those values out where you can see them.
Double-clicking a footprint brings up part selection. Double-clicking a part in the selector assigns the part.
Don't search for the existing LCSC value -- if I'm searching, that's presumably the only part I don't want! Tweak the search string to make it easier to find passives quickly.
Fix for little typo
|
I tested your PR, and I like it so far. The double click event on the part selector is not working (at least on Windows 11). It works on the mainwindows however because there we use a But at te moment I hav no time for that 😓 |
|
Let me test your PR for a little longer and I'll merge it if I don't see any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several commits in this PR, sorry. However, they are all independent, so you can apply whichever you approve of.
They're all small conveniences except the "Show parameters derived from LCSC description" commit, which addresses the following pain points:
LCSC often buries the most important data (like the resistance of a resistor) at the end of the description field. For example: "50mW Thick Film Resistors ±200ppm/℃ ±1% 234kΩ". The "234kΩ" is past the point where the part details dialog truncates the description. (And that dialog is not resizable, which is one of the minor fixes.)
When choosing a part, the values aren't visible in the list. If you search for "5kΩ" you'll also get "25kΩ", "1.5kΩ", etc. and you can't see which is which without opening the details dialog.
When double-checking the assignments, you can't just look down the footprint list to be sure the values are sane, because you can't see the values.
This commit tries to address this by implementing heuristics to pull the important data out of the LCSC description field and show it in the footprint and parts lists. For example:
You can easily scan the list to make sure the values and footprints match.
In part selection:
It's easy to tell the 5.1k from the 51k from the 1k.
This (in addition to implementing double-click in another commit) has vastly accelerated my workflow.
There's one other minor change to note: I altered the default setting of
lcsc_priority. With the current setting, my experience as a new user was that I put in 15 minutes of work assigning parts, closed the dialog, and immediately lost all my work because I didn't know to click the "export" button. It seems safer to default the other way.