Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write permissions for coverage on pull requests #153

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

Bouni
Copy link
Owner

@Bouni Bouni commented Feb 6, 2024

I hope this fixes the last issue in #151

Copy link

github-actions bot commented Feb 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py14311023%39–55, 62–67, 70, 74–79, 84–88, 101–104, 111, 115, 119, 123, 134, 137–140, 143–163, 166–181, 184–201, 204–219, 223–225, 229–230, 234–235
   __main__.py21210%3–49
   datatypes.py2751296%38, 43, 48, 58, 73–76, 81–84, 93
   discover.py433421%26–78
luxtronik/scripts
   dump_changes.py44440%5–93
   dump_luxtronik.py28280%5–64
TOTAL63724961% 

Tests Skipped Failures Errors Time
116 4 💤 0 ❌ 0 🔥 0.651s ⏱️

@Bouni
Copy link
Owner Author

Bouni commented Feb 6, 2024

OK, this indeed fixes the coverage problem you have noticed in #151
After merging this, rebase #151 and we should be back on track

Copy link
Collaborator

@gerw gerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lets try!

@gerw gerw merged commit 0a27251 into main Feb 6, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants