Code hints in foreach

[TomMalbran]

I've been using this extension and saw this bug. I was writing something like: foreach ($fields as $f|, where | is the cursor. I then got some hints at $f and I chose $field. But then it replaced $fields, so I got foreach ($field| instead of foreach ($fields as $field|.

After some testing I saw that this bug only happens when the variable for the array starts with the same letters as the variable for the value. If I have foreach ($array as $v| the codehints do not replace $array when I select something like $value for the second variable. If I have foreach ($fields as $fo| the codehints do not replace $fields when I select something like $foo for the second variable.

[mackenza]

@TomMalbran it was actually worse than your test case. Basically any time you did a 2nd replacement on the same line with another word that started the same way, it would get rid of the rest of the line and insert the first occurrence again.

I switched to using lastIndexOf() and it seems to be fine now.

Can you give it a quick test with the issue-5 branch to confirm it works with your test case?

[TomMalbran]

I thought it might be a bigger issue that just in the foreach, but I didn't tested with anything else.

Using lastIndexOf() seems to fix the issue.
Thanks

[TomMalbran]

I guess you could also use currentToken.start?