Should I add Dark = true

[wormeyman]

https://github.com/adobe/brackets/blob/b568b676e4d2fe0aadfb757e39cfd52444ea3101/src/extensions/default/ThorDarkTheme/package.json#L12

Shows an added entry in the theme file for thor dark, is this a permanent inclusion? If i am jumping the gun i am sorry just wondering what this does and if i should include it.

[MiguelCastillo]

Hey Eric, so the flag won't do much right now. But we are planning on making use of it at later point. I wouldn't really worry about adding right now.

[wormeyman]

ok thanks.

[MiguelCastillo]

Your welcome

[mackenza]

I added it to Railcasts and Envy... then I don't need to change when they make use of it ;)

[wormeyman]

Good plan @mackenza

[MiguelCastillo]

@wormeyman @mackenza I have added a class in the DOM and we are making use of it now. So, if you don't use the dark flag the theme will probably render a bit differently. The flag only currently affects scrollbars and inline editors.

[wormeyman]

Thanks for the heads up Miguel i am going to re-open this to double check that everything still works ok.

[mackenza]

Both Railcasts and Envy have dark: true. Which commits are affecting inline editors @MiguelCastillo ? My scrollbars seem fine (although having a dark scroll bar on an otherwise light dialog like the extension manager looks a bit odd), but my inline editors are mostly unreadable, even with the new "dark" default theme.

[wormeyman]

@mackenza my son deleted your comment, so sorry!

[MiguelCastillo]

Haha!

[mackenza]

@wormeyman lol... that's a first for me on GH ;) No worries!

this is as of adobe/brackets@6e8c643

[MiguelCastillo]

@mackenza this is where we are currently using dark https://github.com/adobe/brackets/blob/master/src/styles/brackets_theme_default.less#L171

We are working through inline editor right now... so I dont know what else will look different right now. But the point is that it is good that the dark flag is in the package.json :)

[mackenza]

the color: #333 for .inline-widget doesn't seem to be taking effect in the above screen shot.

[wormeyman]

http://youtu.be/NM3eZyy-BUA

I told him to say sorry ;)

[MiguelCastillo]

OMG too cute!! :D

On Wed, Jul 23, 2014 at 11:34 AM, Eric J notifications@github.com wrote:

http://youtu.be/NM3eZyy-BUA

I told him to say sorry ;)

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[mackenza]

omg lol... that was classic. Tell him that it's all good and he can go
back to being him ;)

On Wed, Jul 23, 2014 at 11:34 AM, Eric J notifications@github.com wrote:

http://youtu.be/NM3eZyy-BUA

I told him to say sorry ;)

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

[wormeyman]

I'm at work now, and I do not seem to see any difference either, i did setup my own styling for quick docs/edit though.

https://github.com/Brackets-Themes/RubyBlue/blob/master/RubyBlueTheme.less#L177

[MiguelCastillo]

This is the current PR for styling dark inline widget adobe/brackets#8529

[MiguelCastillo]

@wormeyman Also, all dark themes have been moved to css... And some of the less variables have changed, so currently easy dark and ruby blue are broken. I would wait to fix anything until that PR is merged.

[wormeyman]

oh boy life is exciting living on the edge.

[MiguelCastillo]

haha, no worries man, I already have a fix for the issue. waiting to settle the inline widget stuff and then we can fix the issue. its really simple

[MiguelCastillo]

@wormeyman Themes is ready!! So, we should be able to test this theme in master with the dark flag. I would look in particular for the inline widgets. E.g. the css color editor... We should be able to close this issue either way.