run_async's response_stream is a generator and not an async generator #67 #68
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I maybe broke something -- don't have time now to troubleshoot whether it's my proposal that's incorrect or if the test is faulty (perhaps related to a change in the implementation since stream_response_async is deprecated? I haven't looked at the previous implementation) but more details are in #67. |
|
Indeed some failing tests, no worries! |
|
@jonchun Hi, could you perhaps update the tests |
|
Taking a look |
|
Fix was trivial although a bit tricky because pytest didn't give me line numbers... issue was the mock function that was defined for streaming partials was async but needed to be sync because the generator was updated to be synchronous in the original PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #67