Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22 bug logging in jupyter notebooks #27

Merged
merged 5 commits into from
Feb 1, 2024
Merged

22 bug logging in jupyter notebooks #27

merged 5 commits into from
Feb 1, 2024

Conversation

MarcelRosier
Copy link
Collaborator

Based on other feature => Review #25 first.

Cleans up logging strucutre and fixes rerun bug in jupyter notebooks.

Limitation:

  • Exceptions that occur in jupyter ar eonly visible in the cell output, not the log file (See here for why). In normal script executions all exceptions are still logged properly (including sigint and sigterm)

@MarcelRosier MarcelRosier self-assigned this Jan 30, 2024
@MarcelRosier MarcelRosier linked an issue Jan 30, 2024 that may be closed by this pull request
[bug] logging in Jupyter notebooks #22
Closed
neuronflow
neuronflow approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@neuronflow neuronflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neuronflow neuronflow merged commit 02e74bc into main Feb 1, 2024
2 checks passed
@neuronflow neuronflow deleted the 22-bug-logging-in-jupyter-notebooks branch February 1, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuronflow neuronflow neuronflow approved these changes

Assignees

@MarcelRosier MarcelRosier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] logging in Jupyter notebooks
2 participants
@MarcelRosier @neuronflow