Enhancement: Allow use of optimize options and add recommended config
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
options
branch
5 times, most recently
from
0d1a3b6 to
4436f39
Compare
|
Hi @brettz9 this looks like a really thorough and well thought out improvement. I will take a closer look at it soon. Thanks for contributing! |
… at Node 6
- Enhancement: Allow use of `optimize` options
- Enhancement: Add `recommended` and `all` configs which avoid need for `plugins` and `rules` together
- Linting: Apply eslint:recommended, with a few additional rules and an ignore file
- Travis: Update from 7 to check 8, 10, 12
- npm: Add recommended fields (bugs, homepage, contributors); use https URL for
auto-opening within IDEs and linting against package.json validator
- npm: Add `eslint` script
- npm: Update devDeps
- Maintenance: `.editorconfig` to enforce spacing on Markdown
- Testing: Add nyc coverage
|
I've rebased on the latest changes and reconciled the |
|
Just a friendly reminder if you could take a look when you have a chance... |
tests/lib/rules/optimize-regex.js
Outdated
| 'var foo = /baz/i', | ||
| 'var foo = /bar/mig', | ||
| 'var foo = /\\/\\./', | ||
| 'var foo = /[/\\\\]$/', | ||
| { | ||
| code: 'var re = /[0-9]/', | ||
| output: 'var re = /\\d/', |
There was a problem hiding this comment.
if we backlisted charClassToMeta, should this output be like this? shouldn't it still be var re = /[0-9]/? maybe I'm missing something
There was a problem hiding this comment.
Whoops, yes, you're right. Fixed.
I also added a test using blacklist which was still failing.
|
@brettz9 this somehow slipped out of my view. I left a comment, but besides that it looks good |
|
@brettz9 thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimizeoptionsrecommendedandallconfigs which avoid need forpluginsandrulestogetherauto-opening within IDEs and linting against package.json validator
eslintscript.editorconfigto enforce spacing on MarkdownWhile we could avoid the breaking change by toggling to an older version of nyc in Travis for Node 6, with many projects dropping support even for Node 8 (which has reached Node end-of-life support), I think it may be easier to just drop the support (and avoid any inconsistencies in the nyc coverage results between the different nyc versions).