Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twilio sms Api added #452

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

DipuBala
Copy link
Contributor

@DipuBala DipuBala commented Sep 13, 2022

Description

(Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.)

Type of change

(Please delete options that are not relevant.)

  • Link to a GH Issue or Jira task here for reference.
  • Bug fix
  • New feature

How Has This Been Tested?

(Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration)

  • Tested by myself
  • Unit test

Developer Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Review check list:

  • Separation of Concerns followed (Reviewer name/NaN)
  • Code is in sync with existing code patterns/technologies. (Reviewer name/NaN)
  • Are there any obvious optimizations that will improve performance? (Reviewer name/NaN)
  • Can any logging or debugging code be removed? (Reviewer name/NaN)
  • Are all data inputs checked (for the correct type, length, format, and range) and encoded? (Reviewer name/NaN)
  • Are invalid parameter values handled? (Reviewer name/NaN)
  • Is error handling done the correct way? (Reviewer name/NaN)
  • Are all the edge cases (null, 0, negative) handled properly? (Reviewer name/NaN)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants