Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update help links in various pages #71

Merged
merged 3 commits into from
Jun 25, 2024
Merged

chore: Update help links in various pages #71

merged 3 commits into from
Jun 25, 2024

Conversation

samkeleN
Copy link
Collaborator

@samkeleN samkeleN commented Jun 25, 2024

PR Type

Enhancement


Description

  • Updated 'Contact' links to 'Help' links across multiple HTML files.
  • Changed href attributes to point to walletDirect.html for consistency.

Changes walkthrough 📝

Relevant files
Enhancement
12 files
index.html
Update 'Contact' link to 'Help' in footer.                             

index.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    Profile.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/Wallet profile/Profile.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    auth.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/auth/auth.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    index.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/auth/gamepin/gamepinUI/index.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    index.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/auth/gamepin/index.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    login.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/auth/login.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    host.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/play/host/host.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    lobby.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/play/lobby.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    post-quiz.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/play/post-quiz.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    quiz.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/play/quiz.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    ranking.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/ranking.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     
    profile.html
    Update 'Contact' link to 'Help' in footer.                             

    pages/user/profile.html

  • Updated 'Contact' link to 'Help' link.
  • Changed href to point to walletDirect.html.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Summary by Sourcery

    This pull request updates the 'Contact' links to 'Help' links across multiple pages to enhance user navigation and provide direct access to the help section.

    • Enhancements:
      • Updated 'Contact' links to 'Help' links across various pages to improve user navigation.

    Copy link
    Contributor

    sourcery-ai bot commented Jun 25, 2024

    Reviewer's Guide by Sourcery

    This pull request updates the 'Contact' links across various pages to 'Help' and changes the href attribute to point to '/pages/walletAuth/walletDirect.html' or the appropriate relative path. This change ensures that users are directed to the correct help page.

    File-Level Changes

    Files Changes
    index.html
    pages/Wallet profile/Profile.html
    pages/auth/auth.html
    pages/auth/gamepin/gamepinUI/index.html
    pages/auth/gamepin/index.html
    pages/auth/login.html
    pages/play/host/host.html
    pages/play/lobby.html
    pages/play/post-quiz.html
    pages/play/quiz.html
    pages/ranking.html
    pages/user/profile.html
    Updated 'Contact' links to 'Help' and changed the href to point to '/pages/walletAuth/walletDirect.html' or relative paths as appropriate.

    Tips
    • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
    • You can change your review settings at any time by accessing your dashboard:
      • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
      • Change the review language;
    • You can always contact us if you have any questions or feedback.

    @codiumai-pr-agent-pro codiumai-pr-agent-pro bot added the enhancement New feature or request label Jun 25, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 2
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review Consistency in Path References:
    Some href attributes use relative paths while others start from the root. This inconsistency might lead to broken links depending on the deployment environment or base URL configuration.
    Possible Broken Links:
    Ensure that all updated links to 'walletDirect.html' are valid and that the file exists at the specified paths in all cases.

    Copy link
    Contributor

    codiumai-pr-agent-pro bot commented Jun 25, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Use a relative path for the help link to maintain consistency and avoid potential issues

    Ensure that the new help link uses a relative path similar to the login link for
    consistency and to avoid potential issues with different environments.

    index.html [98]

    -<a href="/pages/walletAuth/walletDirect.html"><i class="bx bx-envelope"></i><p>Help</p></a>
    +<a href="./pages/walletAuth/walletDirect.html"><i class="bx bx-envelope"></i><p>Help</p></a>
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion correctly identifies the inconsistency in path usage and recommends using a relative path for better consistency and reliability across different environments.

    7

    Copy link

    github-actions bot commented Jun 25, 2024

    Visit the preview URL for this PR (updated for commit 4721fcb):

    https://brainiacwiz--pr71-sam-395vay9o.web.app

    (expires Tue, 02 Jul 2024 21:31:50 GMT)

    🔥 via Firebase Hosting GitHub Action 🌎

    Sign: aff57accd7fb79ba1d7bf7e70bd8fcad77b0db3f

    Copy link
    Contributor

    @sourcery-ai sourcery-ai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hey @samkeleN - I've reviewed your changes and they look great!

    Here's what I looked at during the review
    • 🟡 General issues: 1 issue found
    • 🟢 Security: all looks good
    • 🟢 Testing: all looks good
    • 🟢 Complexity: all looks good
    • 🟢 Documentation: all looks good

    Sourcery is free for open source - if you like our reviews please consider sharing them ✨
    Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

    index.html Outdated Show resolved Hide resolved
    Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
    Copy link

    cloudflare-workers-and-pages bot commented Jun 25, 2024

    Deploying brainiacwiz with  Cloudflare Pages  Cloudflare Pages

    Latest commit: 4721fcb
    Status: ✅  Deploy successful!
    Preview URL: https://7c65841e.brainiacwiz.pages.dev
    Branch Preview URL: https://sam.brainiacwiz.pages.dev

    View logs

    index.html Outdated Show resolved Hide resolved
    Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com>
    @mmpotulo28 mmpotulo28 merged commit ffcbb9c into beta Jun 25, 2024
    6 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants