Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks #85

Merged
merged 10 commits into from
Jan 20, 2025
Merged

Fix memory leaks #85

merged 10 commits into from
Jan 20, 2025

Conversation

araujo88
Copy link
Member

@araujo88 araujo88 commented Jan 19, 2025

Description

Fixes memory leaks.

Related Issue

Fixes #79

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have documented my changes in the code or documentation
  • I have added tests that prove my changes work (if applicable)
  • All new and existing tests pass

@araujo88 araujo88 added enhancement New feature or request refactor Modify existing working code but keeping the same functionality. CI Continuous integration bugfix Fix for something that wasn't working tests Testing examples and edge cases labels Jan 19, 2025
@araujo88
Copy link
Member Author

Weird, this test pass locally:

tests/test_brainrot.py::test_brainrot_examples[division_by_zero-Error: Division by zero at line 5] PASSED [  4%]

But in the CI in gives segfault:

 FAILED test_brainrot.py::test_brainrot_examples[division_by_zero-Error: Division by zero at line 5] - AssertionError: Output for division_by_zero did not match.
  Expected:
  Error: Division by zero at line 5
  Actual:
  Error: Division by zero at line 5
  Segmentation fault (core dumped)
assert 'Error: Divis...(core dumped)' == 'Error: Divis...ero at line 5'
  
  - Error: Division by zero at line 5
  + Error: Division by zero at line 5
  ?                                  +
  + Segmentation fault (core dumped)

@araujo88 araujo88 changed the title Fix/memory leaks Fix memory leaks Jan 19, 2025
@SIGMazer
Copy link
Contributor

finally no leak anymore

@SIGMazer SIGMazer merged commit f75e66a into main Jan 20, 2025
2 checks passed
@SIGMazer SIGMazer deleted the fix/memory-leaks branch January 20, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for something that wasn't working CI Continuous integration enhancement New feature or request refactor Modify existing working code but keeping the same functionality. tests Testing examples and edge cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valgrind reports of memory leak
3 participants