Compatibility with PHP 8.0 #22
Merged
+143
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FORE MERGE)" This reverts commit 4f4fa1b. Needs restart of Workflow after datetime-factory package release
dominikvoda
reviewed
Apr 19, 2022
| @@ -18,7 +21,7 @@ public function testGetBeginningOfTheDay(string $expectedAtom, string $originAto | |||
|
|
|||
| Assert::assertSame( | |||
| DateTimeFormatter::format($expectedDateTime), | |||
| DateTimeFormatter::format(DateTimeModifier::getBeginningOfTheDay($originDateTime)) | |||
| DateTimeFormatter::format(DateTimeModifier::getBeginningOfTheDay($originDateTime)), | |||
There was a problem hiding this comment.
is it the standard now?
There was a problem hiding this comment.
Yep, see BrandEmbassy/coding-standard#64
dominikvoda
approved these changes
Apr 19, 2022
|
It's just coding standard bump and CI improvement, merging with a single review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for PHP 8.0, also bumps coding standard version and extends GitHub Actions workflow for easier maintenance.
Builds on BrandEmbassy/datetime-factory#4
I suggest releasing this as a MINOR version (3.3.0).