Extract router from SlimApplicationFactory to RouterFactory #31
Conversation
ghost
mentioned this pull request
Zemistr
changed the title
| removeDefaultHandlers: true # It's recommended to disable original error handling | ||
| # and use your own error handlers suited for needs of your app. | ||
| services: | ||
| - BrandEmbassy\Slim\RouterFactory("%configuration%", ...)::create # Register a router factory |
There was a problem hiding this comment.
@Zemistr it would be nice if this service was registered automatically by extension, so there is no extra step needed :-)
There was a problem hiding this comment.
Hmmm... Yeah... probably I can do that... 😉
|
|
||
| apiDefinitionKey: api # Your API definition will be under this key in "parameters" section. | ||
|
|
||
| slimApi: %configuration% # Configure it |
There was a problem hiding this comment.
I see what you did there, though i would say previous version without saving configuration to a parameter was more readable for me.
There was a problem hiding this comment.
Understand 😉
Agree, this is maybe a too big change also when it is not totally needed.
I will do some changes today.
Stay tuned 😄
|
The original idea was to separate router as dependency for SlimAppFactory to be able to inject the router into Middleware when needed Also there is Brand Embassy router based on slim that we use for normal server side rendering and we thought about unifying it and use just one router. |
|
Unfortunately, you can't use this router. You have to implement |
No description provided.