Add design review markdown file #1
Conversation
|
I see there are some whitespace issues with the parameters in the command syntax, I will fix those |
|
|
||
| - Sample of end-to-end usage | ||
|
|
||
| - Please provide comprehensive examples that don't assume additional setup. It helps the audience understand your feature. |
There was a problem hiding this comment.
plz make sure to add example here.
example,
user create partner configuration for specific SubId/RG and add initial publisher to approved/trusted publishers
user authorize or unauthorize specific publisher by immutableid
user create namespace then channel which in return create partner topic
user activate partner topic and create event subscriptioon
| Gets a channel or lists all channels under a partner namespace. | ||
|
|
||
| PS C:\> Get-AzureEventGridChannel | ||
| [-ResourceGroupName] <String> |
There was a problem hiding this comment.
I was treating it as a positional variable. The only thing that is optional here is the explicit name of the variable, the value is still required.
| [<CommonParameters>] | ||
|
|
||
| PS C:\> Get-AzureEventGridChannel | ||
| [-ResourceId] <String> |
There was a problem hiding this comment.
Is it is a positional variable, the value is still required. Are you saying specifying the parameter should always be required and it shouldn't be a positional variable?
|
|
||
| ```powershell | ||
| NAME | ||
| Update-AzEventGridPartnerDestination |
There was a problem hiding this comment.
need one for Update-AzEventGridPartnerTopic?
PR for reviewing the design review document before submitting it to the PowerShell team.