Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when running code through hotkey #49

Open
1 of 6 tasks
BrandonArmand opened this issue Jul 13, 2020 · 6 comments
Open
1 of 6 tasks

Fix bug when running code through hotkey #49

BrandonArmand opened this issue Jul 13, 2020 · 6 comments
Labels
bug Something isn't working Hacktoberfest up for grabs

Comments

@BrandonArmand
Copy link
Owner

BrandonArmand commented Jul 13, 2020 •
edited
Loading

  • Bug
  • Clean up
  • Question
  • Enhancement
  • Suggestion
  • Other

What needs to be done.

When the user presses (ctr+enter), the code runs; however, it will also enter a new line, that needs to be fixed.

SPECS:
Mac - Safari, and Firefox.

Why

The hotkey doesn't pause input.

How

One solution that might work could be by pausing text input when control is being held.
@BrandonArmand BrandonArmand added bug Something isn't working up for grabs labels Jul 13, 2020
@OmarShezan
Copy link
Contributor

I can't recreate this issue but let's see if anyone else has this problem.

ram170 added a commit to ram170/Binari that referenced this issue Sep 28, 2020
@ram170
Fix bug when running code through hotkey BrandonArmand#49
e2a7899 
Hi. This is my first open source PR.
Fixes issue BrandonArmand#49
@ram170
Copy link
Contributor

ram170 commented Sep 28, 2020

Hi @BrandonArmand ! Can I take this? The change for this is very minimal, so I'd like to take one more issue if that's not a problem.

@BrandonArmand
Copy link
Owner Author

BrandonArmand commented Sep 28, 2020 •
edited
Loading

Hi @BrandonArmand ! Can I take this? The change for this is very minimal, so I'd like to take one more issue if that's not a problem.

@ram170 Sure thing. It seems to be a bug for macs. Goodluck!

@ram170
Copy link
Contributor

ram170 commented Sep 28, 2020

Hi @BrandonArmand ! Can I take this? The change for this is very minimal, so I'd like to take one more issue if that's not a problem.

@ram170 Sure thing. It seems to be a bug for macs. Goodluck!

Yup. Checked it. Thank you!

@ram170 ram170 mentioned this issue Sep 30, 2020
Merged
@ram170
Copy link
Contributor

ram170 commented Oct 2, 2020

@BrandonArmand Can you review and merge this PR #61 ?

BrandonArmand added a commit that referenced this issue Oct 17, 2020
@BrandonArmand
Merge pull request #61 from ram170/master
df93b4c 
Fix bug when running code through hotkey #49
@chintanpuggalok
Copy link

is it still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Hacktoberfest up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BrandonArmand @OmarShezan @ram170 @chintanpuggalok