Added interfaces to allow for mocks in unit testing #11
Conversation
SimpleTCP/SimpleTcpClient.cs
Outdated
| Message WriteLineAndGetReply(string data, TimeSpan timeout); | ||
| } | ||
|
|
||
| public class SimpleTcpClient : ISimpleTcpClient, IDisposable |
There was a problem hiding this comment.
I'd pull the IDisposable inheritance into the ISimpleTcpClient interface?
|
Haven't reviewed yet - you guys know if this breaks any existing usage (is this a major or minor rev)? |
|
Any idea when this PR is going to be merged and released? |
| bool AutoTrimStrings { get; set; } | ||
| SimpleTcpClient Connect(string hostNameOrIpAddress, int port); | ||
| SimpleTcpClient Disconnect(); | ||
| TcpClient TcpClient { get; } |
There was a problem hiding this comment.
As long as .NET's TcpClient is not interfaced, ISimpleTcpClient won't help to mock Connected property.
|
I raised this PR a while ago due to not being able to mock the SimpleTcpClient (and thus making testing more difficult). At the time I worked around this issue (rather than waiting for the merge). As of right now I am no longer using the SimpleTcpClient and given the time taken to get this PR merged, I'm assuming it's not that much use to anyone else, so could probably be closed? |
Fixes #10