-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BI-2156 - Upgrade Apache Tika to 2.3.0+ #432
Conversation
also removed hard-coded transitive dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to import traits without error
pom.xml
Outdated
@@ -91,10 +91,9 @@ | |||
<mockito.version>4.3.1</mockito.version> | |||
<brapi-java-client.version>2.1-SNAPSHOT</brapi-java-client.version> | |||
<commons-io.version>2.11.0</commons-io.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the commons-io.version needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was unnecessary, I removed it. Thanks.
@@ -378,36 +377,16 @@ | |||
<artifactId>brapi-java-client</artifactId> | |||
<version>${brapi-java-client.version}</version> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume tika is pulling all these in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, maven pulls those in to build tika as they are dependencies of tika. I don't know how common or advisable it is to hard-code transitive dependencies with maven projects, I used trial and error to determine that maven did the right thing for all the transitive dependencies besides apache commons compress, which I hard-coded. I think the issue might have been that two primary dependencies of bi-api both depend on apache commons compress, and maven was defaulting to using a version that didn't work with tika.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Test
Description
Story: BI-2156
Testing
You may need to do a maven
clean install
.Checklist: