-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BI-2372 Create Deltabreed List Controller #434
base: develop
Are you sure you want to change the base?
Conversation
e35a615
to
095342f
Compare
private void makeCall(Request brapiRequest) throws ApiException { | ||
OkHttpClient client = new OkHttpClient.Builder() | ||
.readTimeout(5, TimeUnit.MINUTES) | ||
.build(); | ||
try { | ||
client.newCall(brapiRequest).execute(); | ||
} catch (IOException e) { | ||
log.error("Error calling BrAPI Service", e); | ||
throw new ApiException("Error calling BrAPI Service"); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmeidlin could you make makeCall
a static method in a utility class or something like that so that all the DAOs that issue similar delete requests can reuse it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlm483 You'll want to merge in the latest version of that method. I modified it to handle exceptions like a 404 response from the brapi server.
Description
Story: BI-2372
Please include a summary of the change that was made.
Dependencies
Testing
Testing is satisfied by successful testing of BI-2373.
Checklist: