BI-2372 Create Deltabreed List Controller #434
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeidlin
force-pushed
the
feature/BI-2372
branch
from
e35a615
to
095342f
Compare
mlm483
reviewed
Nov 21, 2024
Comment on lines
228
to
238
| private void makeCall(Request brapiRequest) throws ApiException { | ||
| OkHttpClient client = new OkHttpClient.Builder() | ||
| .readTimeout(5, TimeUnit.MINUTES) | ||
| .build(); | ||
| try { | ||
| client.newCall(brapiRequest).execute(); | ||
| } catch (IOException e) { | ||
| log.error("Error calling BrAPI Service", e); | ||
| throw new ApiException("Error calling BrAPI Service"); | ||
| } | ||
| } |
There was a problem hiding this comment.
@dmeidlin could you make makeCall a static method in a utility class or something like that so that all the DAOs that issue similar delete requests can reuse it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2372
Please include a summary of the change that was made.
Dependencies
Brapi Java Testserver hackathon/delete-germplasm
Testing
Please include any details needed for reviewers to test this code
Checklist: