fix: ExecutionResult with triggers #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 27 27
Lines 1338 1338
=======================================
Hits 1202 1202
Misses 136 136 ☔ View full report in Codecov by Sentry. |
|
This looks great! Thanks for hitting the corners I haven't had a chance to touch yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've just run across your project and loving it :)
I noticed a few edge cases where
ExecutionResultwith triggers (stop-loss, take-profit, etc.) would causeSerde data did not match any variant of untagged enumerror, and it turns out that some of theTriggerDescriptionfields should be optional.I've added the fix and an additional test to cover it. Please feel free to let me know what you think. Thanks!