User nav #96
Merged
User nav #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create, appears the user was never getting created.
…logic for reseting cookies, not part of story
VinceCarollo
approved these changes
May 22, 2019
| @@ -16,6 +14,10 @@ def create | |||
| end | |||
| end | |||
|
|
|||
| def logout | |||
| reset_session | |||
There was a problem hiding this comment.
Is this the best/idiomatic way of doing this?
# removes :person from session
session[:person] = nil
or you can remove the entire session with reset_session.
Answered my own question! From the Rails Docs
| context 'as a visitor' do | ||
| describe 'navbar includes the following' do | ||
| it 'a link to return to the welcome / home page of the application ("/")' do | ||
| visit root_path |
There was a problem hiding this comment.
Do we want the Navbar on the Welcome page?
|
|
||
|
|
||
|
|
||
| user_2 = User.create!(name: "User_1", role: 0, active: true, password_digest: "8320280282", address: "333", city: "Denver", zip: "80000", email: "user_1@gmail.com", state: 'IL' ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
satisfies #80.
Notice route for
get '/logout', to: 'sessions#logout'was needed for testing.