Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding condition to the valid promotersetsig filters #112

Merged

Conversation

cmatKhan
Copy link
Member

@cmatKhan cmatKhan commented Sep 6, 2024

This adds "condition" to the valid promotersetsig filters. Setting this to anything other than 'unknown' essentially selects only harbison_chip records.

The harbison_chip conditions are listed here:

https://github.com/cmatKhan/yeastregulatorydb/blob/5c7625c881d669ad80795cfaca0568fb09ab3278/yeastregulatorydb/regulatory_data/models/Binding.py#L17

We more or less should be using only YPD

@cmatKhan cmatKhan requested a review from ejiawustl September 6, 2024 19:40
Copy link
Collaborator

@ejiawustl ejiawustl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ejiawustl ejiawustl merged commit 1d94413 into BrentLab:dev Sep 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants