-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding interactor ols entry #127
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -540,6 +540,127 @@ def examine_bootstrap_coefficients( | |||
return fig, significant_coefs_dict | |||
|
|||
|
|||
def get_significant_predictors( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ended up in the source code, but it offers both methods, the bootstrap or the lassoCV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other thing i should mention here is that generate_modeling_data has type checking on the inputs already. by checking the method, taht should cover the range of input to this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This has pretty large changes to the lasso_modeling.py, the tutorial and it adds an entry point.