Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding interactor ols entry #127

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

cmatKhan
Copy link
Member

This has pretty large changes to the lasso_modeling.py, the tutorial and it adds an entry point.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cmatKhan cmatKhan requested a review from ejiawustl November 19, 2024 19:32
@@ -540,6 +540,127 @@ def examine_bootstrap_coefficients(
return fig, significant_coefs_dict


def get_significant_predictors(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ended up in the source code, but it offers both methods, the bootstrap or the lassoCV

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing i should mention here is that generate_modeling_data has type checking on the inputs already. by checking the method, taht should cover the range of input to this function

Copy link
Collaborator

@ejiawustl ejiawustl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ejiawustl ejiawustl merged commit 59f9154 into BrentLab:dev Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants