-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added additional code to output intermediate modeling results in main.py #128
Conversation
yeastdnnexplorer/__main__.py
Outdated
os.makedirs(bootstrap_results_dir, exist_ok=True) | ||
|
||
# Save "all" results | ||
ci_dict_all = lasso_res["all"]["ci_dict"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not bother outputing the alphas.
There is repeated code here. The only thing that is different here is 'all' or 'top10'. DRY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure the names of the output tables are the same. since it is going into args.output_dirpath/<response_tf>/
, you do not need to append the response_tf to the filename
Co-authored-by: Chase Mateusiak <chasem@wustl.edu>
Co-authored-by: Chase Mateusiak <chasem@wustl.edu>
Co-authored-by: Chase Mateusiak <chasem@wustl.edu>
Co-authored-by: Chase Mateusiak <chasem@wustl.edu>
Co-authored-by: Chase Mateusiak <chasem@wustl.edu>
Co-authored-by: Chase Mateusiak <chasem@wustl.edu>
Co-authored-by: Chase Mateusiak <chasem@wustl.edu>
…trap models, and updated the interactor_workflow function in main.py to accurately return a single directory with all intermediate and final results
"sig_coefs": sig_coef_dict, | ||
"predictors": X, | ||
"response": y, | ||
"classes": stratification_classes, | ||
} | ||
# this adds the bootstrap lasso outputs so that we can create our own CIs | ||
if method == "bootstrap_lassocv": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the output typing needed to change -- it doesn't look like it did.
We'll make this an issue for later -- I think it is probably better to return this key no matter what, and fill it with None
when the method isn't bootstrap_lasso
.
If you change output in the future, do adjust the docstring :return:
documentation, too
# Save the results from bootstrapping for further analysis | ||
if args.method == "bootstrap_lassocv": | ||
# Iterate through "all" and "top" | ||
for suffix, lasso_results in lasso_res.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok -- This looks good. I didn't pull it to run it -- I trust you did.
good work -- thank you for making the revisions
No description provided.