sp_Blitz - correctly check permissions for sys.traces #3597
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3581. The idea here is to check ALTER TRACE permissions on server level and not ALTER on sys.traces itself.
Here is an extended script from the issue. Added third test for sp_Blitz with ALTER TRACE granted. With that we can see DBCC DROPCLEANBUFFERS reported (yeah added it there so no copy, paste, execute into production). It shows the check itself works.