Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for Item Rename Framework #2

Merged
merged 1 commit into from
May 26, 2020

Conversation

SzwedzikPL
Copy link

@SzwedzikPL SzwedzikPL commented May 26, 2020

When merged this pull request will:

  • Rename addRenamedItem function to renameInventoryItem
  • Add params with typecheck, hasInterface & empty class check & header comment for public use in - renameInventoryItem function
  • Make functions & namespace local as @commy2 suggested.
  • Rename getInventoryClassname function to getInventoryItemData

Tweak initDisplayInventory function to:

  • Make Rename Item Framework work if Item Context Framework options are not present
  • Not run if no ItemContextMenuOptions and renamedItems are present
  • Not register Item Context Framework event handlers if ItemContextMenuOptions are not present
  • Not register Item Rename framework handlers if renamedItems are not present
  • Change exitWith to normal if for checking ctrlShown because exitWith will exit whole loop before checking rest of controls

…ntory;

Rename addRenamedItem function to renameInventoryItem
Add params with typecheck, hasInterface & empty class check & header comment for public use in renameInventoryItem function
Make functions & namespace local
Rename getInventoryClassname function to getInventoryItemData

Tweak initDisplayInventory function to:
  - Make Rename Item Framework work if Item Context Framework options are not present
  - Not not run if no ItemContextMenuOptions and renamedItems are present
  - Not not register Item Context Framework event handlers if ItemContextMenuOptions are not present
  - Not register Item Rename framework handlers if renamedItems are not present
  - Change exitWith to normal if for checking ctrlShown becouse exitWith will exit whole loop before checking rest of controls
@BrettMayson BrettMayson merged commit 1777319 into BrettMayson:rename May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants