Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace: fix span extraction with length of 1 #748

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Conversation

PabstMirror
Copy link
Collaborator

fixes
if (true) then { a } else { b };

push true
callFunction if;
push [{},{}]
callOperator then

I couldn't find any examples of the warn triggering, so I don't see any harm in adding it

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.3%. Comparing base (3c142e1) to head (b2c4518).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libs/workspace/src/reporting/processed.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/workspace/src/reporting/processed.rs 89.0% <50.0%> (-0.9%) ⬇️

@BrettMayson BrettMayson merged commit 9187177 into main Sep 1, 2024
31 checks passed
@BrettMayson BrettMayson deleted the unicodeWork branch September 1, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants