Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: better cli handling, table output format #833

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Conversation

BrettMayson
Copy link
Owner

I just wanted to add --format json, fell down a rabbit hole and rewrote all the CLI parsing from Clap's builder API to derive API

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 21.40221% with 213 lines in your changes missing coverage. Please review.

Project coverage is 68.9%. Comparing base (7f055cd) to head (82d35d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/src/utils/paa/inspect.rs 0.0% 29 Missing ⚠️
bin/src/commands/localization/coverage.rs 0.0% 27 Missing ⚠️
bin/src/utils/pbo/inspect.rs 0.0% 22 Missing ⚠️
bin/src/lib.rs 57.4% 20 Missing ⚠️
bin/src/commands/launch/mod.rs 0.0% 16 Missing ⚠️
bin/src/commands/utils.rs 0.0% 14 Missing ⚠️
bin/src/utils/inspect.rs 0.0% 7 Missing ⚠️
bin/src/utils/pbo/extract.rs 0.0% 7 Missing ⚠️
bin/src/main.rs 0.0% 6 Missing ⚠️
bin/src/utils/pbo/mod.rs 0.0% 6 Missing ⚠️
... and 21 more
Additional details and impacted files
Files with missing lines Coverage Δ
bin/src/commands/book.rs 0.0% <0.0%> (-33.4%) ⬇️
bin/src/commands/check.rs 0.0% <0.0%> (-12.5%) ⬇️
bin/src/commands/mod.rs 85.7% <0.0%> (-14.3%) ⬇️
bin/src/commands/script.rs 88.8% <66.6%> (-11.2%) ⬇️
bin/src/commands/wiki.rs 0.0% <0.0%> (-61.6%) ⬇️
bin/src/utils/config/inspect.rs 0.0% <0.0%> (ø)
bin/src/commands/build.rs 85.1% <81.8%> (-8.3%) ⬇️
bin/src/commands/new/mod.rs 74.0% <60.0%> (-5.3%) ⬇️
bin/src/commands/release.rs 85.0% <66.6%> (-12.5%) ⬇️
bin/src/commands/value.rs 0.0% <0.0%> (-9.1%) ⬇️
... and 21 more

@BrettMayson BrettMayson merged commit 83ef17c into main Nov 10, 2024
21 of 23 checks passed
@BrettMayson BrettMayson deleted the output_format branch November 10, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant