Skip to content

Commit

Permalink
Support PhpStorm in launchEditor (facebook#2622)
Browse files Browse the repository at this point in the history
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.
  • Loading branch information
Mikhail Osher authored and morgs32 committed Sep 1, 2017
1 parent 47eb592 commit e44f02e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/react-dev-utils/launchEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ function getArgumentsForLineNumber(editor, fileName, lineNumber, workspace) {
);
case 'webstorm':
case 'webstorm64':
case 'phpstorm':
case 'phpstorm64':
return addWorkspaceToArgumentsIfExists(
['--line', lineNumber, fileName],
workspace
Expand Down

0 comments on commit e44f02e

Please sign in to comment.