Skip to content

Commit

Permalink
test: convert new tests to use error types
Browse files Browse the repository at this point in the history
PR-URL: nodejs#18581
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
jackhorton authored and BridgeAR committed Feb 10, 2018
1 parent 93bbe4e commit 1729af2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions test/addons-napi/test_typedarray/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ arrayTypes.forEach((currentType) => {
const template = Reflect.construct(currentType, buffer);
assert.throws(() => {
test_typedarray.CreateTypedArray(template, buffer, 0, 136);
}, /Invalid typed array length/);
}, RangeError);
});

const nonByteArrayTypes = [ Int16Array, Uint16Array, Int32Array, Uint32Array,
Expand All @@ -71,5 +71,5 @@ nonByteArrayTypes.forEach((currentType) => {
test_typedarray.CreateTypedArray(template, buffer,
currentType.BYTES_PER_ELEMENT + 1, 1);
console.log(`start of offset ${currentType}`);
}, /start offset of/);
}, RangeError);
});
3 changes: 1 addition & 2 deletions test/parallel/test-console-assign-undefined.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ assert.strictEqual(global.console, 42);
common.expectsError(
() => console.log('foo'),
{
type: TypeError,
message: 'console.log is not a function'
type: TypeError
}
);

Expand Down

0 comments on commit 1729af2

Please sign in to comment.