assert: show proper differences

Right now it is possible to get an AssertionError from input that has
the customInspect function set to always return the same value.

That way the error message is actually misleading because the output
is going to look the same. This fixes it by deactivating the custom
inspect function.

PR-URL: nodejs#18611
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

lib/internal/errors.js

@@ -90,9 +90,9 @@ function createErrDiff(actual, expected, operator) {
  var skipped = false;
  const util = lazyUtil();
  const actualLines = util
- .inspect(actual, { compact: false }).split('\n');
+ .inspect(actual, { compact: false, customInspect: false }).split('\n');
  const expectedLines = util
- .inspect(expected, { compact: false }).split('\n');
+ .inspect(expected, { compact: false, customInspect: false }).split('\n');
  const msg = `Input A expected to ${operator} input B:\n` +
  `${green}+ expected${white} ${red}- actual${white}`;
  const skippedMsg = ' ... Lines skipped';
@@ -235,8 +235,10 @@ class AssertionError extends Error {
  } else if (errorDiff === 1) {
  // In case the objects are equal but the operator requires unequal, show
  // the first object and say A equals B
- const res = util
- .inspect(actual, { compact: false }).split('\n');
+ const res = util.inspect(
+ actual,
+ { compact: false, customInspect: false }
+ ).split('\n');
 
  if (res.length > 20) {
  res[19] = '...';

test/parallel/test-assert.js

@@ -899,7 +899,11 @@ common.expectsError(
  message: `${start}\n` +
  `${actExp}\n` +
  '\n' +
- ' {}'
+ `${minus} {}\n` +
+ `${plus} {\n` +
+ `${plus} loop: 'forever',\n` +
+ `${plus} [Symbol(util.inspect.custom)]: [Function]\n` +
+ `${plus} }`
  });
 
  // notDeepEqual tests