Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid inclusion #1

Closed
Poussinou opened this issue Sep 24, 2022 · 14 comments
Closed

F-Droid inclusion #1

Poussinou opened this issue Sep 24, 2022 · 14 comments
Labels
enhancement New feature or request

Comments

@Poussinou
Copy link
Contributor

Hi,

Since this app is GPLv3 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team?

@Poussinou Poussinou added the enhancement New feature or request label Sep 24, 2022
@BrightDV
Copy link
Owner

Hi,

Since this app is GPLv3 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team?

I planned to do it, I have made a fastlane folder with screenshots & descriptions. However, I hadn't that much time and I tried to understand how to submit to F-Droid, but I didn't figure it out...
I would agree if someone adds it to F-Droid, but in this case, would I have to do some changes to the repo?

@Poussinou
Copy link
Contributor Author

I started the process by opening a Request For Packaging.

Our F-Droid bot will scan this repo and tell us some information, and we'll see if something is needed. Otherwise we can move forward and submit the app to the repo here.

@licaon-kter
Copy link

licaon-kter commented Sep 27, 2022

;) pls test https://gitlab.com/fdroid/rfp/-/issues/2219#note_1116002503

And a small request: can the "Check Update" menu entry be removed? Makes no sense for F-Droid.

@BrightDV
Copy link
Owner

Thanks a lot for the work!
I added the latest changelog to the fastlane folder and the metadata file on GitLab looks good to me.

And a small request: can the "Check Update" menu entry be removed? Makes no sense for F-Droid.

Do you mean the button in the settings? If so, it is for users who want a faster update or who do not have F-Droid, like NewPipe does.

@licaon-kter
Copy link

@BrightDV yes, but I'd like to remove that useless entry, as users can't really update to your version since this app is not build reproducible, right?

Maybe you have a bit of sed magic that we can apply before build? :)

@BrightDV
Copy link
Owner

What do you mean by build reproducible?

@licaon-kter
Copy link

@BrightDV
Copy link
Owner

So as I saw, you need my signing key? For the first releases, I hadn't a signing key, but since v0.0.3 I use one, with apksigner.
Is this file what is needed to make builds reproducibles?
Sorry if I misunderstand...

@licaon-kter
Copy link

licaon-kter commented Sep 28, 2022

No, basically F-Droid builds the APK, it compares it to your APK for this version, if they are identical then F-Droid uses your APK directly (with your signature). There's no extra signing, F-Droid does not need your key, etc.

just that it is hard to make your app build reproducible, hence there are fewer of them.

When this happens users can update to your APKs so the update function makes sense. Else... it does not, it will just confuse the users.

@BrightDV
Copy link
Owner

BrightDV commented Sep 28, 2022

So as you asked, I removed the entry for update check.
Do I need to do anything else?

@licaon-kter
Copy link

I guess not, I'l rebuild asap to verify, thanks.

@licaon-kter
Copy link

Looking good!

@licaon-kter
Copy link

@BrightDV
Copy link
Owner

Thanks a lot!

BrightDV pushed a commit that referenced this issue Jul 8, 2023
…-white-background

Fix subtabs white textcolor on white background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants