Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] View race times #130

Closed
symbuzzer opened this issue Feb 27, 2024 · 16 comments
Closed

[FEATURE] View race times #130

symbuzzer opened this issue Feb 27, 2024 · 16 comments
Labels
enhancement New feature or request
Milestone

Comments

@symbuzzer
Copy link
Contributor

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
We should be able to view race times. local time if possible.

Describe alternatives you've considered
The time may also be included at the bottom of the race days in the schedule tab.

Additional context

@symbuzzer symbuzzer added the enhancement New feature or request label Feb 27, 2024
@BrightDV
Copy link
Owner

Hello,
The times should already be accessible if you tap on the race, then view results. You can even add the event to your calendar, so I think it would be a bit redundant if it is also added there.
Also, if you still see the 2023 calendar, deleting the app's data or waiting 1 week should switch the season to 2024.

@symbuzzer
Copy link
Contributor Author

İt isnt user-friendly, sorry. Anyway I found race times. Thanks

@BrightDV
Copy link
Owner

İt isnt user-friendly, sorry. Anyway I found race times. Thanks

You mean tapping on the grand-prix? If so, I might think of a way to suggest it. Any UI feedback is always good for me, because as I know the app, I don't know if something is unclear or if it is not good UX.

@symbuzzer
Copy link
Contributor Author

Green Local Time, Red UMT
fec9ea78-31a8-42f7-9de7-09ca9a0d8fd6

@symbuzzer symbuzzer reopened this Feb 28, 2024
@BrightDV
Copy link
Owner

BrightDV commented Mar 1, 2024

I think that there may be some overflow on small device, so what about the current implementation, with the times under the circuit name? (Like a 3 line item)

@alanbjoseph
Copy link

alanbjoseph commented Mar 8, 2024

That sounds wonderful. Maybe include only the Qualifying and Race Time (Sprint Race too if available)
Also, I think UMT isn't that necessary. App users might be pleased with just the local time.

[ANOTHER FEATURE REQUEST] - I very well think I'm supposed to do this in a new issue, but I'm just unsure.
'Add to calendar' option would be wonderful in the 'Race Hub' as well, when you click on an event specific.
Currently it just shows the time remaining up to the event.

@BrightDV BrightDV added this to the 0.7.3 milestone Mar 9, 2024
@BrightDV
Copy link
Owner

BrightDV commented Mar 9, 2024

That sounds wonderful. Maybe include only the Qualifying and Race Time (Sprint Race too if available)
Also, I think UMT isn't that necessary. App users might be pleased with just the local time.

What do you think is the best:

  • Q:[Start hour of the qualifs] - R: [Start hour of the race] -> strange on sprint weekends?
  • [Start hour of the race] - [End hour of the race] -> might be confusing if only the race?
  • [Start date of the GP] - [End date of the GP]

[ANOTHER FEATURE REQUEST] - I very well think I'm supposed to do this in a new issue, but I'm just unsure.
'Add to calendar' option would be wonderful in the 'Race Hub' as well, when you click on an event specific.
Currently it just shows the time remaining up to the event.

No problem, that seems doable too, so I hope in 0.7.3 too!

@alanbjoseph
Copy link

alanbjoseph commented Mar 10, 2024

Just the start hour of the Qualifs, the race and the sprint race (if any) would be best for me.

Q:[Start hour of the qualifs] - R: [Start hour of the race]

This is exactly what I'm talking about.

strange on sprint weekends?

Maybe add an extra row, so it might look something like:

  • Q:[Start hour of the qualifs] - R: [Start hour of the race]
  • S:[Start hour of the sprint race]

This added row, if only there is a sprint race.
I'm unsure about it too, I just hope someone comes up with a better suggestion.

@BrightDV
Copy link
Owner

BrightDV commented Mar 10, 2024

I did some UI tests, what do you think feels better?

Race + date Date Start hour of race Hour above date Hour under date

@symbuzzer
Copy link
Contributor Author

Definitely 5 "Hour above date"

@alanbjoseph
Copy link

alanbjoseph commented Mar 11, 2024

'Start hour of the race' feels good to me.

Adding anything to box with the date on the left- looks really crowded, i.e. 'Hour above date' and 'Hour below date'.

The date is already mentioned in the box on the left. So, 'Race + Date' and 'Date' seem unnecessary.

[FUTURE REFERENCE]
This might take time, so need not work on it straight away.

Clicking on a race would bring a 'drop-down' or a 'pop-up' menu with all the session details, such as Free Practices, Qualifyings and Race - Dates and Times.
While the main screen (the default as of now), just shows the main race time.

Cheers.

@Rafee-M
Copy link
Contributor

Rafee-M commented Mar 13, 2024

Definitely 3, "start hour of race" as well. It is the most minimal and provides all the necessary information required.

@BrightDV
Copy link
Owner

So I added the third choice, it will be available in the next release.
Thanks for your help!

@symbuzzer
Copy link
Contributor Author

Screenshot_20240423-105811_Box, Box!

Has text issues sir

@alanbjoseph
Copy link

Has text issues sir

Working just fine on my device.
You sure restarting the app doesn't fix it?

@BrightDV
Copy link
Owner

Has text issues sir

Working just fine on my device. You sure restarting the app doesn't fix it?

It depends of the width of the screen, see #146 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants