Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Formula E #166

Merged
merged 24 commits into from
Jul 4, 2024
Merged

Add Formula E #166

merged 24 commits into from
Jul 4, 2024

Conversation

BrightDV
Copy link
Owner

@BrightDV BrightDV commented Jun 25, 2024 •
edited
Loading

Checklist

Articles List

  • Offline cache
  • Online fetch, with new pages...

Article Reader

  • Text renderer
  • Image renderer
  • Player renderer
  • Open another article
  • Open article in webview if parsed content is empty

Videos

  • Videos list
  • Video player

Standings

  • Offline cache
  • Online fetch
  • Drivers
  • Teams

Schedule

  • Last and upcoming
  • Offline cache

Results

  • Understand how a weekend works
  • Results
  • Offline race result access

Event Tracker

  • Replacement ? At least, not F1's one

Compatibility

  • Update offline saves keys to be championship-specific
  • Check for any errors.
  • Update history entries → must have a championship value (default is f1 to avoid update crashes)
  • Fix Formula E video downloads Remove video download (HLS streams not supported)
  • Update download keys (championship-specific)
  • Try to find regressions

Settings

  • Localization
  • Set championship-specific settings

Test

  • Test
  • Change championship while offline

@BrightDV BrightDV linked an issue Jun 25, 2024 that may be closed by this pull request
Please add also e-prix (formula E) #152
Closed
@BrightDV BrightDV marked this pull request as draft June 26, 2024 09:40
BrightDV added 18 commits June 26, 2024 12:21
@BrightDV
[news] support offline cache
7639147
@BrightDV
[standings] add formula e
fd672f2
@BrightDV
[schedule] add formula e
c54503d
@BrightDV
[results] add formula e
3ca4c9a
@BrightDV
[standings] add images
792acd2
@BrightDV
[results] add team colors; add circuit images
904508b
@BrightDV
[circuit] add articles to know when the session load is finished
e21a429
@BrightDV
[article] fix author; support opening a related article
c9df27a
@BrightDV
[videos] add formula e
b8ea385
@BrightDV
[article] support formula e articles' deeplink
4586c36
@BrightDV
[player] fix video download regression
b9d8bdd
@BrightDV
[database] use championship-specific keys
4e4a3aa
@BrightDV
[downloader] disable video download for Formula E because it is not s…
beef87e 
…upported (hls streams only)
@BrightDV
[history] support multi-championship articles (and opening)
947584b
@BrightDV
[results] fix for the guy who has no team; improve results
4adbe01
@BrightDV
[download] make article downloads championship-specific
88b288f
@BrightDV
[settings] add champ-specific settings; ability to refresh championsh…
3c62d50 
…ipid for formula e (new season)
@BrightDV
[racehub] add an event tracker for formula e; new webview for fe
b07ca7d
@BrightDV BrightDV marked this pull request as ready for review July 3, 2024 09:20
BrightDV
BrightDV commented Jul 4, 2024
View reviewed changes
Copy link
Owner Author

@BrightDV BrightDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first part of review: one thing to change, one to review
(in case not saved: needs to review: fp screen, race_details, fe api, racehub, live session indicator, news, fe scraping)

lib/Screens/free_practice_screen.dart Show resolved Hide resolved
lib/Screens/session_screen.dart Show resolved Hide resolved
BrightDV
BrightDV commented Jul 4, 2024
View reviewed changes
Copy link
Owner Author

@BrightDV BrightDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BrightDV
Copy link
Owner Author

BrightDV commented Jul 4, 2024

Will need to test the event tracker against formula 1 data during silverstone.

@BrightDV BrightDV merged commit 68dbadb into main Jul 4, 2024
@BrightDV BrightDV deleted the formula-e branch July 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add also e-prix (formula E)
1 participant
@BrightDV