Merge pull request #681 from deepakhj/snmpraw_fix

Fixes issue with collect_snmp stepping over the same devices multiple times
BrightcoveOS · Jul 23, 2014 · 54e43c3 · 54e43c3
2 parents baff5c2 + 4227f37
commit 54e43c3
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/collectors/snmpraw/snmpraw.py b/src/collectors/snmpraw/snmpraw.py
@@ -161,11 +161,8 @@ def collect_snmp(self, device, host, port, community):
         self.log.debug(
             'Collecting raw SNMP statistics from device \'{0}\''.format(device))
 
-        for device in self.config['devices']:
-            dev_config = self.config['devices'][device]
-            if not 'oids' in dev_config:
-                continue
-
+        dev_config = self.config['devices'][device]
+        if 'oids' in dev_config:
             for oid, metricName in dev_config['oids'].items():
 
                 if (device, oid) in self.skip_list: