Improvements to the hadoop collector. #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements two major changes necessary to use the hadoop collector in a production environment. The first change divides the time by 1000 as the time reported in the metrics files are miliseconds since epoch. Without this change the following error is thrown from graphite: struct.error: 'L' format requires 0 <= number <= 4294967295 The second change included here is a truncation step to the file read. Without a truncation step the metrics file will grow forever, and each run will re-read the whole metrics file, sending all the old, as well as the new metrics to the graphite server. By truncating the file after a successful read we can stop not only the disks from filling up, but we can also ensure that we never overload the graphite server by re-sending massive numbers of metrics. This change is optional, and defaulted to false in order to maintain current semantics.
kormoc
added a commit
that referenced
this pull request
Jul 23, 2014
Improvements to the hadoop collector.
|
Thanks! And sorry it took so long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements two major changes necessary to use the hadoop
collector in a production environment. The first change divides the time
by 1000 as the time reported in the metrics files are miliseconds since
epoch. Without this change the following error is thrown from graphite:
struct.error: 'L' format requires 0 <= number <= 4294967295
The second change included here is a truncation step to the file read.
Without a truncation step the metrics file will grow forever, and each
run will re-read the whole metrics file, sending all the old, as well as
the new metrics to the graphite server. By truncating the file after a
successful read we can stop not only the disks from filling up, but we
can also ensure that we never overload the graphite server by re-sending
massive numbers of metrics. This change is optional, and defaulted to
false in order to maintain current semantics.